rawtherapee.com Forum Index rawtherapee.com
Support Forum
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

RawTherapee 3.0 alpha 1 released.
Goto page Previous  1, 2, 3, 4, 5  Next
 
Post new topic   Reply to topic    rawtherapee.com Forum Index -> General Discussion
View previous topic :: View next topic  
Author Message
Fer



Joined: 15 May 2008
Posts: 62
Location: Rome, Italy

PostPosted: 10th Feb 2010, Wed, 09:15    Post subject: Reply with quote

Me, I don't like the output from enfuse.
Too much halos, just look at the white truck. Confused
Back to top
View user's profile Send private message
DrSlony



Joined: 02 Dec 2007
Posts: 934
Location: London, Rainy Kingdom

PostPosted: 10th Feb 2010, Wed, 19:11    Post subject: Reply with quote

I forgot to mention one thing with that digiKam's enfuse preview: in the original result the clouds were less bright and more saturated with blue, so I decided to only use the enfused part of the buildings and keep the original clouds. Sorry for not mentioning this earlier, but I don't think it makes a big difference regarding the topic being discussed: your algorithm. The point is that this image is a great test image (I believe I specifically had you in mind, Ben, when I shot it) and digiKam's enfuse did a great job overall, better than what I could come up with using command-line vanilla enfuse.

Someone named Mickey sent me his version of my photo, and the results are very impressive, no halos at all! You can post them here and explain what you did, whether it was in RT or outside.
Back to top
View user's profile Send private message Visit poster's website
mmickey



Joined: 11 Feb 2010
Posts: 36

PostPosted: 11th Feb 2010, Thu, 14:55    Post subject: Reply with quote

Here are the two versions, a natural one and an "enhanced" one...





It is done outside of rawtherapee in my development version of dlRaw-preview... the workflow to get such results is developed by myself. The plan is to publish it as a complete program, once it is "final".

greets mike
Back to top
View user's profile Send private message Visit poster's website
ben_pcc



Joined: 15 Oct 2009
Posts: 45

PostPosted: 15th Feb 2010, Mon, 18:31    Post subject: Reply with quote

Not working very hard due to being busy with other things, but I'm happy with this so far:

Without:

http://web.cecs.pdx.edu/~ben_s/Linked/RTTest01/0072-1.jpg

With (takes extra 20 s):

http://web.cecs.pdx.edu/~ben_s/Linked/RTTest01/0072.jpg


My favorite part is how you can actually see the car tires as more then flat blackness. This is a great test image, thanks for thinking of me :->

The math framework is solid but there's so many ways to apply it. Sadly, I had to tweak more then one parameter to make it work nice on this image. Though those settings work good on most images I tried it on.

I slowed it down a little with my newer additions but there's still one more trick to speed it up (preconditioning) I haven't properly done yet.
Back to top
View user's profile Send private message
paul.matthijsse



Joined: 07 Oct 2008
Posts: 653
Location: Dieulefit, France

PostPosted: 16th Feb 2010, Tue, 15:57    Post subject: Reply with quote

Here's my version. In RT I made five versions, going from dark to very light (16-bit tif). Then i ran enfuse. The resulting photo (still way too dark) was corrected in Digikam (autoexp, curves, vivid colors). Then I did Digikams local contrast (yep, 2nd time that enfuse works here!), some sharpening and downsizing, saved as 8-bit jpg.

Back to top
View user's profile Send private message
eduperez



Joined: 23 Jan 2008
Posts: 81

PostPosted: 17th Feb 2010, Wed, 07:45    Post subject: Reply with quote

paul.matthijsse wrote:
Here's my version. In RT I made five versions, going from dark to very light (16-bit tif). Then i ran enfuse. The resulting photo (still way too dark) was corrected in Digikam (autoexp, curves, vivid colors). Then I did Digikams local contrast (yep, 2nd time that enfuse works here!), some sharpening and downsizing, saved as 8-bit jpg.

[...]


Impressive!
_________________
photoblog.edu-perez.com
Back to top
View user's profile Send private message Visit poster's website
paul.matthijsse



Joined: 07 Oct 2008
Posts: 653
Location: Dieulefit, France

PostPosted: 17th Feb 2010, Wed, 09:08    Post subject: Reply with quote

Thanks! Actually quite close to DrSlony's photo, but without the halos (as far as I can see).
Back to top
View user's profile Send private message
ben_pcc



Joined: 15 Oct 2009
Posts: 45

PostPosted: 3rd Mar 2010, Wed, 23:36    Post subject: Reply with quote

Ok. I did some more work on it over last weekend.

As usual, I'm not applying a tone curve exposure adjustment, or anything else like that so that you see only the effect of the processing I'm working on. The output can be made more visually appealing by adding a curve after it which starts steep.

This processed with RT without anything unusual

This processed with RT with dynamic range compression

Full size you don't see much, except more contrast in the clouds and less contrast elsewhere. Some 100% crops (left, without; right, with) show more items of interest:







I recast the code as standard C when I realized it was almost already that way.
Back to top
View user's profile Send private message
mmickey



Joined: 11 Feb 2010
Posts: 36

PostPosted: 6th Mar 2010, Sat, 23:12    Post subject: Reply with quote

ben_pcc wrote:
Ok. I did some more work on it over last weekend.

As usual, I'm not applying a tone curve exposure adjustment, or anything else like that so that you see only the effect of the processing I'm working on. The output can be made more visually appealing by adding a curve after it which starts steep.

I recast the code as standard C when I realized it was almost already that way.


Thank you very much! Your code gives already very good results. The only thing that bothers me is the calculation time, using it on 14MP images is not so nice right now. Are there further improvements planned?

To help people to test your algorithm I wrapped it into a command line program with a gimp script to call it. More info here: http://www.mm-log.com/blog/2010-03-07/gimp-dynamic-range-compression-fake-hdr

greets mike
Back to top
View user's profile Send private message Visit poster's website
paul.matthijsse



Joined: 07 Oct 2008
Posts: 653
Location: Dieulefit, France

PostPosted: 7th Mar 2010, Sun, 13:26    Post subject: Reply with quote

Hello Mike, is this supposed to work on Gimp 2.7.1 as well?

I compiled the source and copied the resulting drc program and your Python script to the plug-ins folder of Gimp, but your script does not show up under the Filter menu. Same when I copy the two files to the scripts folder.

The command line version works, but it returns a b&w image. Comments in the source code indicate that this is intended. Now what am I supposed to do with this, merge it in Gimp with the original tiff, or what?

Thanks for reading (and for writing your wrapper of course!).

Regards, Paul.
Back to top
View user's profile Send private message
mmickey



Joined: 11 Feb 2010
Posts: 36

PostPosted: 7th Mar 2010, Sun, 13:54    Post subject: Reply with quote

paul.matthijsse wrote:
Hello Mike, is this supposed to work on Gimp 2.7.1 as well?

I compiled the source and copied the resulting drc program and your Python script to the plug-ins folder of Gimp, but your script does not show up under the Filter menu. Same when I copy the two files to the scripts folder.

The command line version works, but it returns a b&w image. Comments in the source code indicate that this is intended. Now what am I supposed to do with this, merge it in Gimp with the original tiff, or what?

Thanks for reading (and for writing your wrapper of course!).

Regards, Paul.


Yes, it works with the latest gimp, I'm using it here... it is a python script, so copy both files in the plug-ins folder not in the scripts folder of gimp.
The script will handle the greyscale image for you... So you don't have to mess with the commandline...

Works now?

greets mike
Back to top
View user's profile Send private message Visit poster's website
paul.matthijsse



Joined: 07 Oct 2008
Posts: 653
Location: Dieulefit, France

PostPosted: 7th Mar 2010, Sun, 14:40    Post subject: Reply with quote

Hello Mike,

No it doesn't work. It is supposed to be under Filters - MM-Filters, isn't it? I don't have this entry.

I copied the two files to /home/user/.gimp-2.7/plug-ins. No luck. Also copied them to /usr/lib/gimp/2.0/plug-ins, no luck again...

Btw. Ubuntu 9.10 32-bit, libtiff and libtiff-dev installed.
Back to top
View user's profile Send private message
mmickey



Joined: 11 Feb 2010
Posts: 36

PostPosted: 7th Mar 2010, Sun, 15:00    Post subject: Reply with quote

paul.matthijsse wrote:
Hello Mike,

No it doesn't work. It is supposed to be under Filters - MM-Filters, isn't it? I don't have this entry.

I copied the two files to /home/user/.gimp-2.7/plug-ins. No luck. Also copied them to /usr/lib/gimp/2.0/plug-ins, no luck again...

Btw. Ubuntu 9.10 32-bit, libtiff and libtiff-dev installed.


Yes it should pop up there...
Are the two files in .../plug-ins set executable?

greets mike
Back to top
View user's profile Send private message Visit poster's website
paul.matthijsse



Joined: 07 Oct 2008
Posts: 653
Location: Dieulefit, France

PostPosted: 7th Mar 2010, Sun, 15:03    Post subject: Reply with quote

yes, both are executable. perhaps I screwed up my gimp...
Back to top
View user's profile Send private message
mmickey



Joined: 11 Feb 2010
Posts: 36

PostPosted: 7th Mar 2010, Sun, 15:22    Post subject: Reply with quote

paul.matthijsse wrote:
yes, both are executable. perhaps I screwed up my gimp...


I'm running out of ideas...
It is possible to start gimp from terminal, then you get an output of all problems with filters and plug-ins... look for the script there... are other python scripts working on your system?
Otherwise, restarting from scratch with gimp python and the script would be my next advice... sorry...

greets mike
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    rawtherapee.com Forum Index -> General Discussion All times are GMT
Goto page Previous  1, 2, 3, 4, 5  Next
Page 3 of 5

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group